-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-12999: Make RecordHeader reads thread-safe #20751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chia7712
merged 10 commits into
apache:trunk
from
mingyen066:KAFKA-12999-Make-RecordHeader-thread-safe
Nov 2, 2025
Merged
KAFKA-12999: Make RecordHeader reads thread-safe #20751
chia7712
merged 10 commits into
apache:trunk
from
mingyen066:KAFKA-12999-Make-RecordHeader-thread-safe
Nov 2, 2025
+68
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Oct 22, 2025
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
|
@mingyen066 please update the |
chia7712
reviewed
Oct 24, 2025
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 25, 2025
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 29, 2025
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Oct 29, 2025
chia7712
reviewed
Oct 30, 2025
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java
Outdated
Show resolved
Hide resolved
TaiJuWu
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mingyen066 please fix the error |
|
@chia7712 fixed. |
chia7712
reviewed
Nov 1, 2025
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Nov 1, 2025
chia7712
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
KIP-1205
to address concurrency issues (NPE) related to the lazy initialization
of
RecordHeaderfields.The added test verified that concurrent access to
RecordHeader.key()and
RecordHeader.value()no longer throwsNullPointerExceptionReviewers: TaiJuWu [email protected], Chia-Ping Tsai
[email protected]